Skip to content

Implement hidden RPC estimaterawfee - #432

Merged
tcharding merged 3 commits into
rust-bitcoin:masterfrom
jamillambert:1217-hidden-estimaterawfee
Dec 29, 2025
Merged

Implement hidden RPC estimaterawfee#432
tcharding merged 3 commits into
rust-bitcoin:masterfrom
jamillambert:1217-hidden-estimaterawfee

Conversation

@jamillambert

Copy link
Copy Markdown
Collaborator

Implement estimaterawfee in the v17 hidden module, add the client macro, model and test.
Add all the reexports for later versions, there are no changes up to v30.

Implement the RPC in v17 hidden module, add the client macro and test.
Add all the reexports for later versions, there are no changes up to
v30.
@0xB10C

0xB10C commented Dec 22, 2025

Copy link
Copy Markdown
Contributor

These changes look Ok to me. The integration test for estimaterawfee makes sense and since it passes, I think the implementation from v17 to v30 is correct.

@tcharding tcharding left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 65e7637

@tcharding
tcharding merged commit c452340 into rust-bitcoin:master Dec 29, 2025
114 of 117 checks passed
tcharding added a commit that referenced this pull request Jan 9, 2026
426e7b3 implement hidden RPC `getorphantxs` (0xb10c)

Pull request description:

  > getorphantxs ( verbosity )
  > Shows transactions in the tx orphanage.

  This implements the hidden `getorphantxs` RPC in the last commit. Depends on #432 and #433. Part of #333.

  Since the `expiry` and `entry` fields were dropped for v30 (this is an experimental RPC after all), there is a `into.rs` implementation for both v29 and v30.

ACKs for top commit:
  jamillambert:
    ACK 426e7b3
  tcharding:
    ACK 426e7b3

Tree-SHA512: 96213742a02382258bb94f4a8842baac79bd1bb3194a7c9ad501f1ece1328a156e3dd141e27bdd96eeac9dd43e90e23ce8aba57cd64902dcf4075a39dab4b35b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants